[rpc] Add Tracking to Subscriptions Made via HTTP for Unused Filter Eviction#18591
Open
onelapahead wants to merge 1 commit intoerigontech:mainfrom
Open
[rpc] Add Tracking to Subscriptions Made via HTTP for Unused Filter Eviction#18591onelapahead wants to merge 1 commit intoerigontech:mainfrom
onelapahead wants to merge 1 commit intoerigontech:mainfrom
Conversation
…viction Signed-off-by: hfuss <hayden.fuss@kaleido.io>
Contributor
Author
|
We've been soaking this in our nodes with success on ensuring unused filters are evicted overtime. This PR is ready for review now. |
onelapahead
requested review from
AskAlexSharov,
Giulio2002,
canepat,
mh0lt and
yperbasis
as code owners
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Then adds a missing feature from Geth: evicting stale filters via a background "timeout" loop. Similar to what was done in okx#777 but hopefully more efficient.
Meant to help avoid accumulate more Go heap for unused filters which only further hurt performance over time.
Also adds metrics for keeping track of the number of filters we have so we can confirm they do not grow indefinitely.